feat(apollo-react): add ad hoc tasks section with play button support [MST-8189]#449
Open
kittyyueli wants to merge 1 commit intomainfrom
Open
feat(apollo-react): add ad hoc tasks section with play button support [MST-8189]#449kittyyueli wants to merge 1 commit intomainfrom
kittyyueli wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
kittyyueli
force-pushed
the
claude/adhoc-tasks-section-MwHFc
branch
2 times, most recently
from
0a82205 to
f832a4d
Compare
…tage node Ad hoc tasks are now rendered in their own non-draggable, non-reorderable section at the bottom of the stage with an "Ad hoc tasks" label and divider. Entry condition icon is no longer shown by default on ad hoc tasks — instead, a new `hasEntryCondition` field on `StageTaskItem` controls per-task display. https://claude.ai/code/session_013Y2Tc2yebLyhnDd1qiCLp5
kittyyueli
force-pushed
the
claude/adhoc-tasks-section-MwHFc
branch
from
f832a4d to
aee682d
Compare
kittyyueli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for displaying ad hoc tasks in a separate section within stage nodes, complete with a dedicated play button for triggering individual tasks.
Key Changes
Separated task rendering: Split regular draggable tasks from ad hoc tasks into distinct sections
New AdhocTaskPlayButton component: Created a memoized button component that:
onTaskPlaycallbackUpdated task filtering logic:
allTasksnow contains all tasks from stageDetailstasksfiltered to exclude ad hoc tasks (for draggable section)adhocTasksfiltered to include only ad hoc tasksNew styled components:
StageAdhocSection: Container with border-top separator and spacingStageAdhocLabel: Label styling for the "Ad hoc tasks" section headerUpdated StageTaskItem interface: Added
hasEntryConditionproperty to support entry condition indicators on ad hoc tasksConditional rendering: Empty state now checks both regular and ad hoc tasks; DndContext only renders when regular tasks exist
Implementation Details
onTaskPlayis provided) and entry condition iconDemo
https://claude.ai/code/session_013Y2Tc2yebLyhnDd1qiCLp5